This repository was archived by the owner on Nov 10, 2024. It is now read-only.
create parameter for making the shape filled or not#67
Open
MoustafaElsaghier wants to merge 2 commits intomreram:masterfrom
Open
create parameter for making the shape filled or not#67MoustafaElsaghier wants to merge 2 commits intomreram:masterfrom
MoustafaElsaghier wants to merge 2 commits intomreram:masterfrom
Conversation
MoustafaElsaghier
force-pushed
the
master
branch
from
70e2bb3 to
bc408e5
Compare
mreram
reviewed
Aug 31, 2022
app/src/main/java/ir/smartdevelop/eram/showcaseview/MainActivity.java
Outdated
Show resolved
Hide resolved
mreram
reviewed
Aug 31, 2022
app/src/main/java/ir/smartdevelop/eram/showcaseview/MainActivity.java
Outdated
Show resolved
Hide resolved
mreram
reviewed
Aug 31, 2022
Owner
mreram
left a comment
mreram
left a comment
There was a problem hiding this comment.
Thank you for your contribution! Could you please update README file and add something regarding your great feature?
MoustafaElsaghier
force-pushed
the
master
branch
from
19ea156 to
f6a9b76
Compare
Author
|
please check again read me file and style revert as requested |
Author
|
any updates to accepting the pull request? |
mreram
suggested changes
Sep 18, 2022
showcaseviewlib/src/main/java/smartdevelop/ir/eram/showcaseviewlib/GuideView.java
Show resolved
Hide resolved
showcaseviewlib/src/main/java/smartdevelop/ir/eram/showcaseviewlib/GuideView.java
Show resolved
Hide resolved
showcaseviewlib/src/main/java/smartdevelop/ir/eram/showcaseviewlib/GuideView.java
Show resolved
Hide resolved
showcaseviewlib/src/main/java/smartdevelop/ir/eram/showcaseviewlib/GuideView.java
Show resolved
Hide resolved
showcaseviewlib/src/main/java/smartdevelop/ir/eram/showcaseviewlib/GuideView.java
Show resolved
Hide resolved
showcaseviewlib/src/main/java/smartdevelop/ir/eram/showcaseviewlib/GuideView.java
Show resolved
Hide resolved
showcaseviewlib/src/main/java/smartdevelop/ir/eram/showcaseviewlib/GuideView.java
Show resolved
Hide resolved
showcaseviewlib/src/main/java/smartdevelop/ir/eram/showcaseviewlib/GuideView.java
Show resolved
Hide resolved
Author
|
any update bro? |
Owner
May I change a little your code style? |
Author
|
Yes of course feel free bro
…On Sun, Nov 13, 2022, 5:22 PM Mohammad Reza Eram ***@***.***> wrote:
any update bro?
May I change a little your code style?
—
Reply to this email directly, view it on GitHub
<#67 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AELECU24OWZARNVHUVXIOMLWIEBVDANCNFSM6AAAAAAQAW6ZQ4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
any updates? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created a simple fork for adding a new features or allowing developers to control in the shape ( arrow - circle ) is solid or not developer can use the following method
isShapeSolid(true)to control if the shape is solid or notalso some of idea auto import and reformate to code sample and library